FIX: Sizing of icons in alerts #3861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perfect thanks lets go with that and in case we notice something else we come back to it :) |
mhsdesign
approved these changes
Sep 27, 2024
laurahaenel
pushed a commit
to laurahaenel/neos-ui
that referenced
this pull request
Oct 2, 2024
|
im not totally sure but i think there are also other cases around in the ui: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
With the FontAwesome icons update the icons in the alerts now are too wide.
How I did it
FontAwesome sets the box-sizing to content box now:
How to verify it
Icons are small again:
Do not know if we should change box-sizing for icons globally or not, but I could not find any other place where it does not work.